pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jacob Champion <jchampion@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: libpq: Align oauth_json_set_error() with other NLS patterns
Date: Mon, 15 Dec 2025 22:28:44 +0000
Message-ID: <E1vVH3b-000yaZ-2A@gemulon.postgresql.org> (raw)

libpq: Align oauth_json_set_error() with other NLS patterns

Now that the prior commits have fixed missing OAuth translations, pull
the bespoke usage of libpq_gettext() for OAUTHBEARER parsing into
oauth_json_set_error() itself, and make that a gettext trigger as well,
to better match what the other sites are doing. Add an _internal()
variant to handle the existing untranslated case.

Suggested-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/0EEBCAA8-A5AC-4E3B-BABA-0BA7A08C361B%40yesql.se
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7a15cff1f11193467898da1c1fabf06fd2caee04

Modified Files
--------------
src/interfaces/libpq/fe-auth-oauth.c | 31 +++++++++++++++++++------------
src/interfaces/libpq/nls.mk          |  2 ++
2 files changed, 21 insertions(+), 12 deletions(-)



view thread (2+ messages)

Message-ID: <E1vVH3b-000yaZ-2A@gemulon.postgresql.org>
Permalink:  ../E1vVH3b-000yaZ-2A@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vVH3b-000yaZ-2A@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: jchampion@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: libpq: Align oauth_json_set_error() with other NLS patterns
  In-Reply-To: <E1vVH3b-000yaZ-2A@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox