pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Clean up test_cloexec.c and Makefile. 4+ messages / 1 participants [nested] [flat]
* pgsql: Clean up test_cloexec.c and Makefile. @ 2025-12-21 04:38 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-21 04:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up test_cloexec.c and Makefile. An unused variable caused a compiler warning on BF animal fairywren, an snprintf() call was redundant, and some buffer sizes were inconsistent. Per code review from Tom Lane. The Makefile's test ifeq ($(PORTNAME), win32) never succeeded due to a circularity, so only Meson builds were actually compiling the new test code, partially explaining why CI didn't tell us about the warning sooner (the other problem being that CompilerWarnings only makes world-bin, a problem for another commit). Simplify. Backpatch-through: 16, like commit c507ba55 Author: Bryan Green <dbryan.green@gmail.com> Co-authored-by: Thomas Munro <tmunro@gmail.com> Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/1086088.1765593851%40sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bec2a0aa306599c59f2b7d35b26eba9864f29c10 Modified Files -------------- src/test/modules/test_cloexec/Makefile | 17 ++------ src/test/modules/test_cloexec/test_cloexec.c | 60 +++++++++------------------- 2 files changed, 23 insertions(+), 54 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Clean up test_cloexec.c and Makefile. @ 2025-12-21 04:38 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-21 04:38 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up test_cloexec.c and Makefile. An unused variable caused a compiler warning on BF animal fairywren, an snprintf() call was redundant, and some buffer sizes were inconsistent. Per code review from Tom Lane. The Makefile's test ifeq ($(PORTNAME), win32) never succeeded due to a circularity, so only Meson builds were actually compiling the new test code, partially explaining why CI didn't tell us about the warning sooner (the other problem being that CompilerWarnings only makes world-bin, a problem for another commit). Simplify. Backpatch-through: 16, like commit c507ba55 Author: Bryan Green <dbryan.green@gmail.com> Co-authored-by: Thomas Munro <tmunro@gmail.com> Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/1086088.1765593851%40sss.pgh.pa.us Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/a7d06e74d51209702fe0712214aac07f863ec36a Modified Files -------------- src/test/modules/test_cloexec/Makefile | 17 ++------ src/test/modules/test_cloexec/test_cloexec.c | 60 +++++++++------------------- 2 files changed, 23 insertions(+), 54 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Clean up test_cloexec.c and Makefile. @ 2025-12-21 04:39 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-21 04:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up test_cloexec.c and Makefile. An unused variable caused a compiler warning on BF animal fairywren, an snprintf() call was redundant, and some buffer sizes were inconsistent. Per code review from Tom Lane. The Makefile's test ifeq ($(PORTNAME), win32) never succeeded due to a circularity, so only Meson builds were actually compiling the new test code, partially explaining why CI didn't tell us about the warning sooner (the other problem being that CompilerWarnings only makes world-bin, a problem for another commit). Simplify. Backpatch-through: 16, like commit c507ba55 Author: Bryan Green <dbryan.green@gmail.com> Co-authored-by: Thomas Munro <tmunro@gmail.com> Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/1086088.1765593851%40sss.pgh.pa.us Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0451859131e530f3f5f906dc148d52011da48268 Modified Files -------------- src/test/modules/test_cloexec/Makefile | 17 ++------ src/test/modules/test_cloexec/test_cloexec.c | 60 +++++++++------------------- 2 files changed, 23 insertions(+), 54 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Clean up test_cloexec.c and Makefile. @ 2025-12-21 04:39 Thomas Munro <tmunro@postgresql.org> 0 siblings, 0 replies; 4+ messages in thread From: Thomas Munro @ 2025-12-21 04:39 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Clean up test_cloexec.c and Makefile. An unused variable caused a compiler warning on BF animal fairywren, an snprintf() call was redundant, and some buffer sizes were inconsistent. Per code review from Tom Lane. The Makefile's test ifeq ($(PORTNAME), win32) never succeeded due to a circularity, so only Meson builds were actually compiling the new test code, partially explaining why CI didn't tell us about the warning sooner (the other problem being that CompilerWarnings only makes world-bin, a problem for another commit). Simplify. Backpatch-through: 16, like commit c507ba55 Author: Bryan Green <dbryan.green@gmail.com> Co-authored-by: Thomas Munro <tmunro@gmail.com> Reported-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/1086088.1765593851%40sss.pgh.pa.us Branch ------ REL_16_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0666ccc16cc2d1b97032e7723601dbf5300d057d Modified Files -------------- src/test/modules/test_cloexec/Makefile | 17 ++------ src/test/modules/test_cloexec/test_cloexec.c | 60 +++++++++------------------- 2 files changed, 23 insertions(+), 54 deletions(-) ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2025-12-21 04:39 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2025-12-21 04:38 pgsql: Clean up test_cloexec.c and Makefile. Thomas Munro <tmunro@postgresql.org> 2025-12-21 04:38 pgsql: Clean up test_cloexec.c and Makefile. Thomas Munro <tmunro@postgresql.org> 2025-12-21 04:39 pgsql: Clean up test_cloexec.c and Makefile. Thomas Munro <tmunro@postgresql.org> 2025-12-21 04:39 pgsql: Clean up test_cloexec.c and Makefile. Thomas Munro <tmunro@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox