From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clean up test_cloexec.c and Makefile.
Date: Sun, 21 Dec 2025 04:38:50 +0000
Message-ID: <E1vXBDV-001rTT-31@gemulon.postgresql.org> (raw)
Clean up test_cloexec.c and Makefile.
An unused variable caused a compiler warning on BF animal fairywren, an
snprintf() call was redundant, and some buffer sizes were inconsistent.
Per code review from Tom Lane.
The Makefile's test ifeq ($(PORTNAME), win32) never succeeded due to a
circularity, so only Meson builds were actually compiling the new test
code, partially explaining why CI didn't tell us about the warning
sooner (the other problem being that CompilerWarnings only makes
world-bin, a problem for another commit). Simplify.
Backpatch-through: 16, like commit c507ba55
Author: Bryan Green <dbryan.green@gmail.com>
Co-authored-by: Thomas Munro <tmunro@gmail.com>
Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/1086088.1765593851%40sss.pgh.pa.us
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a7d06e74d51209702fe0712214aac07f863ec36a
Modified Files
--------------
src/test/modules/test_cloexec/Makefile | 17 ++------
src/test/modules/test_cloexec/test_cloexec.c | 60 +++++++++-------------------
2 files changed, 23 insertions(+), 54 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clean up test_cloexec.c and Makefile.
In-Reply-To: <E1vXBDV-001rTT-31@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox