From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove MsgType type
Date: Sat, 27 Dec 2025 22:46:53 +0000
Message-ID: <E1vZd3k-0031i6-1a@gemulon.postgresql.org> (raw)
Remove MsgType type
Presumably, the C type MsgType was meant to hold the protocol message
type in the pre-version-3 era, but this was never fully developed even
then, and the name is pretty confusing nowadays. It has only one
vestigial use for cancel requests that we can get rid of. Since a
cancel request is indicated by a special protocol version number, we
can use the ProtocolVersion type, which MsgType was based on.
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/505e76cb-0ca2-4e22-ba0f-772b5dc3f230%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b63443718a4a3a50304610e6ccda93bbfa06a1e6
Modified Files
--------------
src/include/libpq/pqcomm.h | 3 +--
src/interfaces/libpq/fe-cancel.c | 4 ++--
src/tools/pgindent/typedefs.list | 1 -
3 files changed, 3 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove MsgType type
In-Reply-To: <E1vZd3k-0031i6-1a@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox