pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: jit: Drop redundant LLVM configure probes.
Date: Tue, 30 Dec 2025 07:29:18 +0000
Message-ID: <E1vaUAP-003RtQ-0f@gemulon.postgresql.org> (raw)

jit: Drop redundant LLVM configure probes.

We currently require LLVM 14, so these probes for LLVM 9 functions
always succeeded.  Even when the features aren't enabled in an LLVM
build, dummy functions are defined (a problem for a later commit).

The whole PGAC_CHECK_LLVM_FUNCTIONS macro and Meson equivalent are
removed, because we switched to testing LLVM_VERSION_MAJOR at compile
time in subsequent work and these were the last holdouts.  That suits
the nature of LLVM API evolution better, and also allows for strictly
mechanical pruning in future commits like 820b5af7 and 972c2cd2.  They
advanced the minimum LLVM version but failed to spot these.

Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA%2BhUKGJgB6gvrdDohgwLfCwzVQm%3DVMtb9m0vzQn%3DCwWn-kwG9w%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a28b4b455df41725ea2115ae2a2fd9b33a20ae5

Modified Files
--------------
config/llvm.m4                 | 17 -----------------
configure                      | 32 --------------------------------
configure.ac                   |  4 ----
meson.build                    |  8 --------
src/backend/jit/llvm/llvmjit.c |  5 -----
src/include/pg_config.h.in     |  8 --------
6 files changed, 74 deletions(-)



Message-ID: <E1vaUAP-003RtQ-0f@gemulon.postgresql.org>
Permalink:  ../E1vaUAP-003RtQ-0f@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vaUAP-003RtQ-0f@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: jit: Drop redundant LLVM configure probes.
  In-Reply-To: <E1vaUAP-003RtQ-0f@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox