From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve portability of new worker_spi test
Date: Tue, 06 Jan 2026 11:25:35 +0000
Message-ID: <E1vd5Bu-004r2B-03@gemulon.postgresql.org> (raw)
Improve portability of new worker_spi test
The new test 002_worker_terminate relies on the generation of a LOG
entry to check that a worker has been started, but missed the fact that
a node set with log_error_verbosity = verbose would add an error code.
The regexp used for the matching check did not take this case into
account, making the test fail on a timeout. The regexp is now fixed to
handle the verbose case correctly.
Per buildfarm member prion, that uses log_error_verbosity = verbose.
The error was reproducible by setting this GUC the same way in the test.
Oversight in f1e251be80a0.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0547aeae0fd6f6d03dd7499c84145ad9e3aa51b9
Modified Files
--------------
src/test/modules/worker_spi/t/002_worker_terminate.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve portability of new worker_spi test
In-Reply-To: <E1vd5Bu-004r2B-03@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox