From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clean up ICU includes.
Date: Wed, 07 Jan 2026 01:20:06 +0000
Message-ID: <E1vdIDV-004zxl-1B@gemulon.postgresql.org> (raw)
Clean up ICU includes.
Remove ICU includes from pg_locale.h, and instead include them in the
few C files that need ICU. Clean up a few other includes in passing.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/48911db71d953edec66df0d2ce303563d631fbe0.camel@j-davis.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/af2d4ca191a4552217eceace21fde6ebc2b85770
Modified Files
--------------
src/backend/commands/collationcmds.c | 4 ++++
src/backend/utils/adt/formatting.c | 8 --------
src/backend/utils/adt/pg_locale.c | 14 ++++++++++++++
src/backend/utils/adt/pg_locale_icu.c | 2 ++
src/backend/utils/adt/varlena.c | 11 ++++++-----
src/include/utils/pg_locale.h | 16 ++++------------
6 files changed, 30 insertions(+), 25 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Clean up ICU includes.
In-Reply-To: <E1vdIDV-004zxl-1B@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox