From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove useless asserts in report_namespace_conflict()
Date: Sun, 18 Jan 2026 07:17:07 +0000
Message-ID: <E1vhN22-0018LD-2i@gemulon.postgresql.org> (raw)
Remove useless asserts in report_namespace_conflict()
An assertion is used in this routine to check that a valid namespace OID
is given by the caller, but it was repeated twice: once at the top of
the routine and a second time multiple times in a switch/case. This
commit removes the assertions within the switch/case.
Thinko in commit 765cbfdc9263.
Author: Man Zeng <zengman@halodbtech.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://postgr.es/m/tencent_40F8C1D82E2EE28065009AAA@qq.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2a6ce34b55e1cbb16a507c2e90c626eef71018b7
Modified Files
--------------
src/backend/commands/alter.c | 6 ------
1 file changed, 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove useless asserts in report_namespace_conflict()
In-Reply-To: <E1vhN22-0018LD-2i@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox