pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve errdetail for logical replication conflict messages.
Date: Wed, 21 Jan 2026 05:07:55 +0000
Message-ID: <E1viQRe-001j8m-2V@gemulon.postgresql.org> (raw)

Improve errdetail for logical replication conflict messages.

This change enhances the clarity and usefulness of error detail messages
generated during logical replication conflicts. The following improvements
have been made:

1. Eliminate redundant output: Avoid printing duplicate remote row and
replica identity values for the multiple_unique_conflicts conflict type.
2. Improve message structure: Append tuple values directly to the main
error message, separated by a colon (:), for better readability.
3. Simplify local row terminology: Remove the word 'existing' when
referring to the local row, as this is already implied by context.
4. General code refinements: Apply miscellaneous code cleanups to improve
how conflict detail messages are constructed and formatted.

Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Shveta Malik <shveta.malik@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/CAHut+Psgkwy5-yGRJC15izecySGGysrbCszv_z93ess8XtCDOQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/48efefa6caacba49ca5b7b84e20c900776e56c50

Modified Files
--------------
doc/src/sgml/logical-replication.sgml      |  23 ++-
src/backend/replication/logical/conflict.c | 248 +++++++++++++++++------------
src/include/replication/conflict.h         |   2 +-
src/test/subscription/t/001_rep_changes.pl |   6 +-
src/test/subscription/t/013_partition.pl   |  14 +-
src/test/subscription/t/029_on_error.pl    |   2 +-
src/test/subscription/t/030_origin.pl      |   4 +-
src/test/subscription/t/035_conflicts.pl   |  42 +++--
8 files changed, 192 insertions(+), 149 deletions(-)



Message-ID: <E1viQRe-001j8m-2V@gemulon.postgresql.org>
Permalink:  ../E1viQRe-001j8m-2V@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1viQRe-001j8m-2V@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Improve errdetail for logical replication conflict messages.
  In-Reply-To: <E1viQRe-001j8m-2V@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox