From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove redundant AssertVariableIsOfType uses
Date: Thu, 22 Jan 2026 11:21:07 +0000
Message-ID: <E1viskM-001yxi-1j@gemulon.postgresql.org> (raw)
Remove redundant AssertVariableIsOfType uses
The uses of AssertVariableIsOfType in pg_upgrade are unnecessary
because the calls to upgrade_task_add_step() already check the
compatibility of the callback functions.
These were apparently copied from a previous coding style, but similar
removals were already done in commit 30b789eafe.
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/3d289481-7f76-409f-81c7-81824219cc75%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f3c96c9dff0c727afd1ef2ea976592c77cc809b5
Modified Files
--------------
src/bin/pg_upgrade/check.c | 23 -----------------------
src/bin/pg_upgrade/function.c | 2 --
src/bin/pg_upgrade/info.c | 5 -----
src/bin/pg_upgrade/version.c | 2 --
4 files changed, 32 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove redundant AssertVariableIsOfType uses
In-Reply-To: <E1viskM-001yxi-1j@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox