pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove incorrect commented out code
Date: Thu, 22 Jan 2026 11:51:12 +0000
Message-ID: <E1vitDT-001zEv-1g@gemulon.postgresql.org> (raw)

Remove incorrect commented out code

These calls, if activated, are happening before null checks, so they
are not correct.  Also, the "in" variable is shadowed later.  Remove
them to avoid confusion and bad examples.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: David Geier <geidav.pg@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/328e4371-9a4c-4196-9df9-1f23afc900df%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/846fb3c7901146a5450c08aeadf50566d5d65d09

Modified Files
--------------
src/backend/utils/adt/jsonfuncs.c | 4 ----
1 file changed, 4 deletions(-)



Message-ID: <E1vitDT-001zEv-1g@gemulon.postgresql.org>
Permalink:  ../E1vitDT-001zEv-1g@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vitDT-001zEv-1g@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove incorrect commented out code
  In-Reply-To: <E1vitDT-001zEv-1g@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox