pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add more tests with clause STORAGE on table and TOAST interactio
Date: Mon, 26 Jan 2026 00:31:28 +0000
Message-ID: <E1vkAVr-002dtl-1o@gemulon.postgresql.org> (raw)

Add more tests with clause STORAGE on table and TOAST interactions

This commit adds more tests to cover STORAGE MAIN and EXTENDED, checking
how these use TOAST tables.  EXTENDED is already widely tested as the
default behavior, but there were no tests where the clause pattern is
directly specified.  STORAGE MAIN and its interactions with TOAST was
not covered at all.

This hole in the tests has been noticed for STORAGE MAIN (inline
compressible varlenas), where I have managed to break the backend
without the tests able to notice the breakage while playing with the
varlena structures.

Reviewed-by: Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>
Discussion: https://postgr.es/m/aXMdX1UTHnzYPkHk@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/168765e5d42be7d3ef750e9e292e14ef94b489e1

Modified Files
--------------
src/test/regress/expected/strings.out | 54 +++++++++++++++++++++++++++++++++++
src/test/regress/sql/strings.sql      | 24 ++++++++++++++++
2 files changed, 78 insertions(+)



Message-ID: <E1vkAVr-002dtl-1o@gemulon.postgresql.org>
Permalink:  ../E1vkAVr-002dtl-1o@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vkAVr-002dtl-1o@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add more tests with clause STORAGE on table and TOAST interactio
  In-Reply-To: <E1vkAVr-002dtl-1o@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox