pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix accidentally cast away qualifiers
Date: Mon, 26 Jan 2026 15:08:18 +0000
Message-ID: <E1vkOCQ-002mI9-07@gemulon.postgresql.org> (raw)

Fix accidentally cast away qualifiers

This fixes cases where a qualifier (const, in all cases here) was
dropped by a cast, but the cast was otherwise necessary or desirable,
so the straightforward fix is to add the qualifier into the cast.

Co-authored-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/b04f4d3a-5e70-4e73-9ef2-87f777ca4aac%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5ca5f12c2c62090f747b5a7d1f5e4adf7f0d161e

Modified Files
--------------
contrib/intarray/_int_selfuncs.c                 |  2 +-
contrib/pageinspect/heapfuncs.c                  |  2 +-
contrib/uuid-ossp/uuid-ossp.c                    |  4 +--
src/backend/access/common/toast_compression.c    |  8 ++---
src/backend/access/nbtree/nbtinsert.c            |  4 +--
src/backend/access/spgist/spgquadtreeproc.c      |  8 ++---
src/backend/access/transam/xloginsert.c          |  4 +--
src/backend/backup/backup_manifest.c             |  2 +-
src/backend/backup/basebackup.c                  |  2 +-
src/backend/backup/basebackup_incremental.c      |  6 ++--
src/backend/executor/nodeIndexscan.c             |  4 +--
src/backend/libpq/auth-scram.c                   |  4 +--
src/backend/libpq/crypt.c                        |  4 +--
src/backend/nodes/nodeFuncs.c                    |  6 ++--
src/backend/nodes/outfuncs.c                     | 12 +++----
src/backend/nodes/tidbitmap.c                    |  4 +--
src/backend/statistics/extended_stats.c          |  4 +--
src/backend/storage/ipc/shm_mq.c                 |  2 +-
src/backend/tsearch/spell.c                      |  4 +--
src/backend/utils/adt/geo_spgist.c               |  4 +--
src/backend/utils/adt/json.c                     |  2 +-
src/backend/utils/adt/pg_locale_builtin.c        |  2 +-
src/backend/utils/adt/rangetypes.c               |  8 ++---
src/backend/utils/adt/rangetypes_gist.c          |  4 +--
src/bin/pg_basebackup/walmethods.c               |  2 +-
src/bin/pg_rewind/filemap.c                      |  4 +--
src/bin/pg_verifybackup/astreamer_verify.c       |  2 +-
src/bin/pg_walsummary/pg_walsummary.c            |  4 +--
src/common/scram-common.c                        |  4 +--
src/common/unicode/case_test.c                   |  2 +-
src/common/unicode_case.c                        |  4 +--
src/include/access/tupmacs.h                     |  2 +-
src/include/common/hashfn_unstable.h             |  2 +-
src/include/utils/memutils.h                     | 12 +++----
src/include/varatt.h                             | 40 ++++++++++++------------
src/interfaces/libpq/fe-auth-scram.c             |  2 +-
src/interfaces/libpq/fe-auth.c                   |  4 +--
src/port/pg_crc32c_armv8.c                       | 10 +++---
src/port/pg_popcount_aarch64.c                   |  4 +--
src/test/isolation/isolationtester.c             |  8 ++---
src/test/modules/libpq_pipeline/libpq_pipeline.c |  2 +-
src/test/modules/test_tidstore/test_tidstore.c   |  8 ++---
42 files changed, 111 insertions(+), 111 deletions(-)



Message-ID: <E1vkOCQ-002mI9-07@gemulon.postgresql.org>
Permalink:  ../E1vkOCQ-002mI9-07@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vkOCQ-002mI9-07@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix accidentally cast away qualifiers
  In-Reply-To: <E1vkOCQ-002mI9-07@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox