public inbox for [email protected]  
help / color / mirror / Atom feed
pgsql: Improve error message for checksum failures in pgstat_database.c
2+ messages / 1 participants
[nested] [flat]

* pgsql: Improve error message for checksum failures in pgstat_database.c
@ 2026-02-13 03:18  Michael Paquier <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2026-02-13 03:18 UTC (permalink / raw)
  To: [email protected]

Improve error message for checksum failures in pgstat_database.c

This log message was referring to conflicts, but it is about checksum
failures.  The log message improved in this commit should never show up,
due to the fact that pgstat_prepare_report_checksum_failure() should
always be called before pgstat_report_checksum_failures_in_db(), with a
stats entry already created in the pgstats shared hash table.  The three
code paths able to report database-level checksum failures follow
already this requirement.

Oversight in b96d3c389755.

Author: Wang Peng <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/775fc014156bdfa6938ef02dce3d85364b1bd220

Modified Files
--------------
src/backend/utils/activity/pgstat_database.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Improve error message for checksum failures in pgstat_database.c
@ 2026-02-13 03:18  Michael Paquier <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Michael Paquier @ 2026-02-13 03:18 UTC (permalink / raw)
  To: [email protected]

Improve error message for checksum failures in pgstat_database.c

This log message was referring to conflicts, but it is about checksum
failures.  The log message improved in this commit should never show up,
due to the fact that pgstat_prepare_report_checksum_failure() should
always be called before pgstat_report_checksum_failures_in_db(), with a
stats entry already created in the pgstats shared hash table.  The three
code paths able to report database-level checksum failures follow
already this requirement.

Oversight in b96d3c389755.

Author: Wang Peng <[email protected]>
Discussion: https://postgr.es/m/[email protected]
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5b0e0c3d03ebbc09ad2534cfb26aa440b21c7ba0

Modified Files
--------------
src/backend/utils/activity/pgstat_database.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-02-13 03:18 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-02-13 03:18 pgsql: Improve error message for checksum failures in pgstat_database.c Michael Paquier <[email protected]>
2026-02-13 03:18 pgsql: Improve error message for checksum failures in pgstat_database.c Michael Paquier <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox