pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Nathan Bossart <nathan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_{dump,restore}: Refactor handling of conflicting options.
Date: Mon, 09 Mar 2026 16:38:35 +0000
Message-ID: <E1vzdcp-003BAF-1H@gemulon.postgresql.org> (raw)

pg_{dump,restore}: Refactor handling of conflicting options.

This commit makes use of the function added by commit b2898baaf7
for these applications' handling of conflicting options.  It
doesn't fix any bugs, but it does trim several lines of code.

Author: Jian He <jian.universality@gmail.com>
Reviewed-by: Steven Niu <niushiji@gmail.com>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://postgr.es/m/CACJufxHDYn%2B3-2jR_kwYB0U7UrNP%2B0EPvAWzBBD5EfUzzr1uiw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7c8280eeb5872f5c2663b562a9c6fcf8ec8a4b82

Modified Files
--------------
src/bin/pg_dump/pg_dump.c           |  69 +++++++----------
src/bin/pg_dump/pg_dumpall.c        |   2 +-
src/bin/pg_dump/pg_restore.c        | 146 +++++++++++++-----------------------
src/bin/pg_dump/t/001_basic.pl      |  26 +++----
src/bin/pg_dump/t/002_pg_dump.pl    |   4 +-
src/bin/pg_dump/t/007_pg_dumpall.pl |   8 +-
6 files changed, 100 insertions(+), 155 deletions(-)



Message-ID: <E1vzdcp-003BAF-1H@gemulon.postgresql.org>
Permalink:  ../E1vzdcp-003BAF-1H@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1vzdcp-003BAF-1H@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: nathan@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: pg_{dump,restore}: Refactor handling of conflicting options.
  In-Reply-To: <E1vzdcp-003BAF-1H@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox