pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: bufmgr: Fix use of wrong variable in GetPrivateRefCountEntrySlow
Date: Wed, 11 Mar 2026 21:56:53 +0000
Message-ID: <E1w0RXx-003Who-2S@gemulon.postgresql.org> (raw)

bufmgr: Fix use of wrong variable in GetPrivateRefCountEntrySlow()

Unfortunately, in 30df61990c67, I made GetPrivateRefCountEntrySlow() set a
wrong cache hint when moving entries from the hash table to the faster array.
There are no correctness concerns due to this, just an unnecessary loss of
performance.

Noticed while testing the index prefetching patch.

Discussion: https://postgr.es/m/CAH2-Wz=g=JTSyDB4UtB5su2ZcvsS7VbP+ZMvvaG6ABoCb+s8Lw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6322a028fa437669022473be8af39bbd89b644c3

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Message-ID: <E1w0RXx-003Who-2S@gemulon.postgresql.org>
Permalink:  ../E1w0RXx-003Who-2S@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w0RXx-003Who-2S@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: bufmgr: Fix use of wrong variable in GetPrivateRefCountEntrySlow
  In-Reply-To: <E1w0RXx-003Who-2S@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox