pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Allow sibling call optimization in slot_getsomeattrs_int()
Date: Sat, 14 Mar 2026 00:52:39 +0000
Message-ID: <E1w1DF8-0003Uf-2Y@gemulon.postgresql.org> (raw)

Allow sibling call optimization in slot_getsomeattrs_int()

This changes the TupleTableSlotOps contract to make it so the
getsomeattrs() function is in charge of calling
slot_getmissingattrs().

Since this removes all code from slot_getsomeattrs_int() aside from the
getsomeattrs() call itself, we may as well adjust slot_getsomeattrs() so
that it calls getsomeattrs() directly.  We leave slot_getsomeattrs_int()
intact as this is still called from the JIT code.

Author: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Discussion: https://postgr.es/m/CAApHDvodSVBj3ypOYbYUCJX%2BNWL%3DVZs63RNBQ_FxB_F%2B6QXF-A%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4deecb52affa4b6f791e8a57f6584610e4dd12f4

Modified Files
--------------
src/backend/executor/execTuples.c | 58 ++++++++++++++++++++-------------------
src/include/executor/tuptable.h   | 13 +++++----
2 files changed, 38 insertions(+), 33 deletions(-)



Message-ID: <E1w1DF8-0003Uf-2Y@gemulon.postgresql.org>
Permalink:  ../E1w1DF8-0003Uf-2Y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w1DF8-0003Uf-2Y@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Allow sibling call optimization in slot_getsomeattrs_int()
  In-Reply-To: <E1w1DF8-0003Uf-2Y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox