pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix aclitemout() to work during early bootstrap.
Date: Sat, 14 Mar 2026 17:47:17 +0000
Message-ID: <E1w1T52-0009cN-2J@gemulon.postgresql.org> (raw)

Fix aclitemout() to work during early bootstrap.

"initdb -d" has been broken since commit f95d73ed4, because I changed
aclitemin to work in bootstrap mode but failed to consider aclitemout.
That routine isn't reached by default, but it is if the elog message
level is high enough, so it needs to work without catalog access too.

This patch just makes it use its existing code paths to print role
OIDs numerically.  We could alternatively invent an inverse of
boot_get_role_oid() and print them symbolically, but that would take
more code and it's not apparent that it'd be any better for debugging
purposes.

Reported-by: Greg Burd <greg@burd.me>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/4416.1773328045@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2eb87345e18e18395bc5051f72c9f4ca30d70c38

Modified Files
--------------
src/backend/utils/adt/acl.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)



Message-ID: <E1w1T52-0009cN-2J@gemulon.postgresql.org>
Permalink:  ../E1w1T52-0009cN-2J@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w1T52-0009cN-2J@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix aclitemout() to work during early bootstrap.
  In-Reply-To: <E1w1T52-0009cN-2J@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox