From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_plan_advice: Fix failures to accept identifier keywords.
Date: Mon, 16 Mar 2026 19:14:54 +0000
Message-ID: <E1w2DOv-0003PG-1s@gemulon.postgresql.org> (raw)
pg_plan_advice: Fix failures to accept identifier keywords.
TOK_IDENT allows only non-keywords; identifier should be used
any place where either keywords or non-keywords should be accepted.
Hence, without this commit, any string that happens to be a keyword
can't be used as a partition schema, partition name, or plan name,
which is incorrect.
Author: Lukas Fittl <lukas@fittl.com>
Discussion: http://postgr.es/m/CAP53PkzKeD=t90OfeMsniYrcRe2THQbUx3g6wV17Y=ZtiwmWTQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5e72ce2467c15340026955b57ff75f75e853a766
Modified Files
--------------
contrib/pg_plan_advice/expected/syntax.out | 45 ++++++++++++++++++++++++++++++
contrib/pg_plan_advice/pgpa_parser.y | 6 ++--
contrib/pg_plan_advice/sql/syntax.sql | 19 +++++++++++++
3 files changed, 67 insertions(+), 3 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_plan_advice: Fix failures to accept identifier keywords.
In-Reply-To: <E1w2DOv-0003PG-1s@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox