pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Tweak TAP test for worker terminations in worker_spi
Date: Tue, 17 Mar 2026 03:57:14 +0000
Message-ID: <E1w2LYP-0006mD-1e@gemulon.postgresql.org> (raw)

Tweak TAP test for worker terminations in worker_spi

The test has been reported as having a race condition for the case of a
worker that should be terminated after a database rename.  Based on the
report received from buildfarm member jay, the database renamed is
accessed by a different session, preventing the ALTER DATABASE to
complete, ultimately failing the test.

Honestly, I am not completely sure what is the origin of this
disturbance, but two possibilities are an autovacuum or parallel worker
(due to debug_parallel_query being used by the host).  In order to
(hopefully) stabilize the test, autovacuum and debug_parallel_query are
now disabled in the configuration of the node used in the test.

The failure is hard to reproduce, so it will take a few weeks to make
sure that the test has become stable.  Let's see where it goes.

Reported-by: Aya Iwata <iwata.aya@fujitsu.com>
Discussion: https://postgr.es/m/OS3PR01MB8889505E2F3E443CCA4BD72EEA45A@OS3PR01MB8889.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/af8837a10bc70d5e815a1bda986429a2a73ad174

Modified Files
--------------
src/test/modules/worker_spi/t/002_worker_terminate.pl | 5 +++++
1 file changed, 5 insertions(+)



Message-ID: <E1w2LYP-0006mD-1e@gemulon.postgresql.org>
Permalink:  ../E1w2LYP-0006mD-1e@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w2LYP-0006mD-1e@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Tweak TAP test for worker terminations in worker_spi
  In-Reply-To: <E1w2LYP-0006mD-1e@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox