From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_plan_advice: Fix multiple copy-and-paste-errors in test case.
Date: Wed, 18 Mar 2026 22:57:56 +0000
Message-ID: <E1w2zpr-000P7P-1Z@gemulon.postgresql.org> (raw)
pg_plan_advice: Fix multiple copy-and-paste-errors in test case.
The second half of this file is meant to test feedback, not
generated advice, and is meant to use the statements that it
prepares, not leftover prepared statements from earlier in the
file.
These mistakes resulted in failures under debug_discard_caches = 1,
because re-executing pt2 instead of executing pt4 for the first
time resulted in different output depending on whether the query
was replanned.
Reported-by: Tom Lane <tgl@sss.pgh.pa.us> (per BF member avocet)
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b335fe56f35506348a567648e3a7ac1b3ac0baf3
Modified Files
--------------
contrib/pg_plan_advice/expected/prepared.out | 14 ++++++++------
contrib/pg_plan_advice/sql/prepared.sql | 6 +++---
2 files changed, 11 insertions(+), 9 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_plan_advice: Fix multiple copy-and-paste-errors in test case.
In-Reply-To: <E1w2zpr-000P7P-1Z@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox