pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Cleanup users and roles in graph_table_rls test
Date: Fri, 20 Mar 2026 10:08:46 +0000
Message-ID: <E1w3Wmb-000csa-1o@gemulon.postgresql.org> (raw)

Cleanup users and roles in graph_table_rls test

This test leaves behind the roles and users it creates.
002_pg_upgrade test dumps and restore the regression when
PG_TEST_EXTRA contains regress_dump_restore.  The global objects such
as users and roles are not dumped by pg_dump.  But it still dumps the
policies associated with users, and commands to set the ownership.
Restoring these policies and the ownerships fails since the users and
roles do not exist.  To fix this failure we could use --no-owner, but
it does not exclude the policy objects associated with users.  Hence
drop the users, roles and policies that depend upon them at the end of
the test.

Author: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Reported-by: Peter Eisentraut <peter@eisentraut.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/a855795d-e697-4fa5-8698-d20122126567@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/040a56be4bcc88cad98f092970a8c6521263bba1

Modified Files
--------------
src/test/regress/expected/graph_table_rls.out | 17 ++++++++++++++++-
src/test/regress/sql/graph_table_rls.sql      | 17 ++++++++++++++++-
2 files changed, 32 insertions(+), 2 deletions(-)



Message-ID: <E1w3Wmb-000csa-1o@gemulon.postgresql.org>
Permalink:  ../E1w3Wmb-000csa-1o@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w3Wmb-000csa-1o@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Cleanup users and roles in graph_table_rls test
  In-Reply-To: <E1w3Wmb-000csa-1o@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox