pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix another buglet in archive_waldump.c.
Date: Sun, 22 Mar 2026 22:48:43 +0000
Message-ID: <E1w4Rb8-000zk9-1Y@gemulon.postgresql.org> (raw)

Fix another buglet in archive_waldump.c.

While re-reading 860359ea0, I noticed another problem: when
spilling to a temp file, it did not bother to check the result
of fclose().  This is bad since write errors (like ENOSPC)
may not be reported until close time.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/69c57466a7521ee146cfdde766713181d45a2d36

Modified Files
--------------
src/bin/pg_waldump/archive_waldump.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



Message-ID: <E1w4Rb8-000zk9-1Y@gemulon.postgresql.org>
Permalink:  ../E1w4Rb8-000zk9-1Y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w4Rb8-000zk9-1Y@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix another buglet in archive_waldump.c.
  In-Reply-To: <E1w4Rb8-000zk9-1Y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox