From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: headerscheck: Get CXXFLAGS from Makefile.global
Date: Mon, 23 Mar 2026 07:00:31 +0000
Message-ID: <E1w4ZH4-0012wu-1Y@gemulon.postgresql.org> (raw)
headerscheck: Get CXXFLAGS from Makefile.global
headerscheck in C++ mode (cpluspluscheck) previously hardcoded
CXXFLAGS and documented that you might need to override them manually
from the environment. Now that we have better C++ support in the
build system, we can just get CXXFLAGS from Makefile.global, like we
do for other variables.
Furthermore, this is necessary in some configurations to make
cpluspluscheck work under meson, because under meson, some -I options
end up in CXXFLAGS where under make they would be in CPPFLAGS.
Therefore, getting the correct CXXFLAGS is required in those cases.
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CAMSWrt-PoQt4sHryWrB1ViuGBJF_PpbjoSGrWR2Ry47bHNLDqg%40mai...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0f17d1dbfa6224b3ab0f4377c593b880be427f31
Modified Files
--------------
src/tools/pginclude/README | 4 ----
src/tools/pginclude/headerscheck | 4 +---
2 files changed, 1 insertion(+), 7 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: headerscheck: Get CXXFLAGS from Makefile.global
In-Reply-To: <E1w4ZH4-0012wu-1Y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox