From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make geometry cast functions error safe
Date: Sun, 29 Mar 2026 18:41:16 +0000
Message-ID: <E1w6v4V-0021zd-1D@gemulon.postgresql.org> (raw)
Make geometry cast functions error safe
This adjusts cast functions of the geometry types to support soft
errors. This requires refactoring of various helper functions to
support error contexts. Also make the float8 to float4 cast error
safe. It requires some of the same helper functions.
This is in preparation for a future feature where conversion errors in
casts can be caught.
(The function casting type circle to type polygon is not yet made error
safe, because it is an SQL language function.)
Author: jian he <jian.universality@gmail.com>
Reviewed-by: Amul Sul <sulamul@gmail.com>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CADkLM%3Dfv1JfY4Ufa-jcwwNbjQixNViskQ8jZu3Tz_p656i_4hQ%40m...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/45cdaf3665bedfbabb908bb84284f3db26781ad3
Modified Files
--------------
src/backend/utils/adt/float.c | 28 ++++-
src/backend/utils/adt/geo_ops.c | 261 +++++++++++++++++++++++++++++-----------
src/include/utils/float.h | 49 ++++++--
3 files changed, 254 insertions(+), 84 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make geometry cast functions error safe
In-Reply-To: <E1w6v4V-0021zd-1D@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox