pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: perl tap: Show failed command output
Date: Thu, 02 Apr 2026 12:25:39 +0000
Message-ID: <E1w8H7C-002bgT-3C@gemulon.postgresql.org> (raw)

perl tap: Show failed command output

Capture stdout and stderr from command_ok() and command_fails() and emit
them as TAP diagnostics on failure.  Output is truncated to the first
and last 30 lines per channel to avoid flooding.

A new helper _diag_command_output() is introduced in Utils.pm so
both functions share the same truncation and formatting logic.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Reviewed-by: Zsolt Parragi <zsolt.parragi@percona.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1402b8d2fc70faa5154cbc26cab8c4ac384880db

Modified Files
--------------
src/bin/pg_ctl/t/001_start_stop.pl     |  2 +-
src/test/perl/PostgreSQL/Test/Utils.pm | 53 ++++++++++++++++++++++++++++++----
2 files changed, 48 insertions(+), 7 deletions(-)



Message-ID: <E1w8H7C-002bgT-3C@gemulon.postgresql.org>
Permalink:  ../E1w8H7C-002bgT-3C@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w8H7C-002bgT-3C@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: perl tap: Show failed command output
  In-Reply-To: <E1w8H7C-002bgT-3C@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox