From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use command_ok for pg_regress calls in 002_pg_upgrade and 027_st
Date: Thu, 02 Apr 2026 12:25:39 +0000
Message-ID: <E1w8H7D-002bgb-09@gemulon.postgresql.org> (raw)
Use command_ok for pg_regress calls in 002_pg_upgrade and 027_stream_regress
Now that command_ok() captures and displays failure output, use it
instead of system() plus manual diff-dumping in these two tests. This
simplifies both scripts and produces consistent, truncated output on
failure.
Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: https://postgr.es/m/DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bb6ae9707c1789c9d2036c9bbd35965a01e1b214
Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 40 ++++++++--------------
src/test/recovery/t/027_stream_regress.pl | 55 +++++++++----------------------
2 files changed, 29 insertions(+), 66 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use command_ok for pg_regress calls in 002_pg_upgrade and 027_st
In-Reply-To: <E1w8H7D-002bgb-09@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox