From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make data checksum tests more resilient for slow machines
Date: Fri, 03 Apr 2026 22:25:54 +0000
Message-ID: <E1w8mxd-002oRr-2o@gemulon.postgresql.org> (raw)
Make data checksum tests more resilient for slow machines
The test for re-running checksum enabling was only checking for the
data checksum state to transition to 'on', but didn't account for
the launcher process having had time to exit, thus getting an error
instead of the expected no-op. Adding a pg_stat_activity check for
the launcher exiting resolves the error, verified by inducing delay
in the launcher.
Also wrap a variable only used in injection point tests within the
correct USE macros to avoid warning for an unused variable.
All per the buildfarm.
Author: Daniel Gustafsson <daniel@yesql.se>
Reported-by: Buildfarm
Discussion: https://postgr.es/m/1CB288C9-564B-4664-B096-C2F4377D17AB@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0036232ba8fb282979cff16c8751a361cb85fe76
Modified Files
--------------
src/test/modules/test_checksums/t/001_basic.pl | 6 +++++-
src/test/modules/test_checksums/test_checksums.c | 2 ++
2 files changed, 7 insertions(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make data checksum tests more resilient for slow machines
In-Reply-To: <E1w8mxd-002oRr-2o@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox