From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove HASH_DIRSIZE, always use the default algorithm to select
Date: Fri, 03 Apr 2026 23:57:54 +0000
Message-ID: <E1w8oOf-002pS8-1D@gemulon.postgresql.org> (raw)
Remove HASH_DIRSIZE, always use the default algorithm to select it
It's not very useful to specify a non-standard directory size. The
HASH_DIRSIZE option was only used for shared memory hash tables, and
those always used hash_select_dirsize() to choose the size, which in
turn just uses the default algorithm anyway. That assumption was
ingrained in hash_estimate_size(), too.
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://www.postgresql.org/message-id/01ab1d41-3eda-4705-8bbd-af898f5007f1@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4953a25b7f3bb5a555342764231157c76e6acbac
Modified Files
--------------
src/backend/storage/ipc/shmem.c | 3 +-
src/backend/utils/hash/dynahash.c | 63 ++++++++-------------------------------
src/include/utils/hsearch.h | 6 +---
3 files changed, 15 insertions(+), 57 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove HASH_DIRSIZE, always use the default algorithm to select
In-Reply-To: <E1w8oOf-002pS8-1D@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox