From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move heapam_handler.c index scan code to new file.
Date: Sat, 04 Apr 2026 15:31:16 +0000
Message-ID: <E1w92xv-002vb8-2f@gemulon.postgresql.org> (raw)
Move heapam_handler.c index scan code to new file.
Move the heapam index fetch callbacks (index_fetch_begin,
index_fetch_reset, index_fetch_end, and index_fetch_tuple) into a new
dedicated file. Also move heap_hot_search_buffer over. This is a
purely mechanical move with no functional impact.
Upcoming work to add a slot-based table AM interface for index scans
will substantially expand this code. Keeping it in heapam_handler.c
would clutter a file whose primary role is to wire up the TableAmRoutine
callbacks. Bitmap heap scans and sequential scans would benefit from
similar separation in the future.
Author: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/bmbrkiyjxoal6o5xadzv5bveoynrt3x37wqch7w3jnwumkq2yo@b4zmtnrfs4mh
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a29fdd6c8d816af0d042491a79c8ec1a60272c06
Modified Files
--------------
src/backend/access/heap/Makefile | 1 +
src/backend/access/heap/heapam.c | 161 ----------------
src/backend/access/heap/heapam_handler.c | 111 -----------
src/backend/access/heap/heapam_indexscan.c | 292 +++++++++++++++++++++++++++++
src/backend/access/heap/meson.build | 1 +
src/include/access/heapam.h | 15 +-
6 files changed, 306 insertions(+), 275 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move heapam_handler.c index scan code to new file.
In-Reply-To: <E1w92xv-002vb8-2f@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox