From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: read_stream: Move logic about IO combining & issuing to helpers
Date: Sun, 05 Apr 2026 05:22:59 +0000
Message-ID: <E1w9Fwo-0031cV-36@gemulon.postgresql.org> (raw)
read_stream: Move logic about IO combining & issuing to helpers
The long if statements were hard to read and hard to document. Splitting them
into inline helpers makes it much easier to explain each part separately.
This is done in preparation for making the logic more complicated...
Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://postgr.es/m/f3xxfrkafjxpyqxywcxricxgyizjirfceychyxsgn7bwjp5eda@kwbduhy7tfmu
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/434dab76ba76fba5dacab2dc695b6b3d5df8315b
Modified Files
--------------
src/backend/storage/aio/read_stream.c | 97 +++++++++++++++++++++++++++++------
1 file changed, 80 insertions(+), 17 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: read_stream: Move logic about IO combining & issuing to helpers
In-Reply-To: <E1w9Fwo-0031cV-36@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox