agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix unportable use of __builtin_constant_p
Date: Mon, 06 Apr 2026 02:31:44 +0000
Message-ID: <E1w9Zkd-003ANs-0k@gemulon.postgresql.org> (raw)
Fix unportable use of __builtin_constant_p
On MSVC Arm, USE_ARMV8_CRC32C is defined, but __builtin_constant_p
is not available. Use pg_integer_constant_p and add appropriate
guards. There is a similar potential hazard for the x86 path, but
for now let's get the buildfarm green.
Oversight in commit fbc57f2bc, per buildfarm member hoatzin.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8194c4a9dd38f7373166ea3fd9243a6e51c0869f
Modified Files
--------------
src/include/port/pg_crc32c.h | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
Message-ID: <E1w9Zkd-003ANs-0k@gemulon.postgresql.org>
Permalink: ../E1w9Zkd-003ANs-0k@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1w9Zkd-003ANs-0k@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix unportable use of __builtin_constant_p
In-Reply-To: <E1w9Zkd-003ANs-0k@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox