agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use PG_DATA_CHECKSUM_OFF instead of hardcoded value
Date: Mon, 06 Apr 2026 20:20:38 +0000
Message-ID: <E1w9qR3-003Hhy-2P@gemulon.postgresql.org> (raw)
Use PG_DATA_CHECKSUM_OFF instead of hardcoded value
For a long time, the online checksums patchset kept the "off" state as
literal zero without a label to be consistent with the previous coding
which only had a label for the "on" state. Later, when an "off" label
was made not all uses in the code got the memo. Fix by setting these
to PG_DATA_CHECKSUM_OFF.
While there, fix a duplicate word in a comment introduced by the same
commit.
Author: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAJ7c6TPRTnQFXXX1CRcYoTLXw2swtDH==uSz1MYoMKdLrKZHjA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b3a37ffbc5b94c0214f1f3f1953e800654a1962f
Modified Files
--------------
src/backend/access/transam/xlog.c | 10 +++++-----
src/backend/bootstrap/bootstrap.c | 2 +-
src/bin/pg_checksums/pg_checksums.c | 4 ++--
src/bin/pg_combinebackup/pg_combinebackup.c | 4 ++--
src/bin/pg_upgrade/controldata.c | 10 +++++-----
src/bin/pg_upgrade/file.c | 2 +-
6 files changed, 16 insertions(+), 16 deletions(-)
Message-ID: <E1w9qR3-003Hhy-2P@gemulon.postgresql.org>
Permalink: ../E1w9qR3-003Hhy-2P@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1w9qR3-003Hhy-2P@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use PG_DATA_CHECKSUM_OFF instead of hardcoded value
In-Reply-To: <E1w9qR3-003Hhy-2P@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox