agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Melanie Plageman <melanieplageman@gmail.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Allocate separate DSM chunk for parallel Index[Only]Scan instrum
Date: Mon, 06 Apr 2026 23:14:53 +0000
Message-ID: <E1w9t9g-003Itk-22@gemulon.postgresql.org> (raw)
Allocate separate DSM chunk for parallel Index[Only]Scan instrumentation
Previously, parallel index and index-only scans packed the parallel scan
descriptor and shared instrumentation (for EXPLAIN ANALYZE) into a
single DSM allocation. Since scans may be instrumented without being
parallel-aware, and vice versa, using separate DSM chunks -- each with
its own TOC key -- is cleaner. A future commit will extend this pattern
to other scan node types.
Author: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://postgr.es/m/flat/a177a6dd-240b-455a-8f25-aca0b1c08c6e%40vondra.me
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dd78e69cfc337f93cfc0303ddf660262d7f1237e
Modified Files
--------------
src/backend/access/index/indexam.c | 51 ++-----------
src/backend/executor/execParallel.c | 40 +++++++---
src/backend/executor/nodeBitmapIndexscan.c | 9 ++-
src/backend/executor/nodeIndexonlyscan.c | 114 +++++++++++++++++------------
src/backend/executor/nodeIndexscan.c | 114 +++++++++++++++++------------
src/include/access/genam.h | 7 +-
src/include/access/relscan.h | 1 -
src/include/executor/instrument_node.h | 8 ++
src/include/executor/nodeIndexonlyscan.h | 6 ++
src/include/executor/nodeIndexscan.h | 6 ++
10 files changed, 202 insertions(+), 154 deletions(-)
Message-ID: <E1w9t9g-003Itk-22@gemulon.postgresql.org>
Permalink: ../E1w9t9g-003Itk-22@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1w9t9g-003Itk-22@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: melanieplageman@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allocate separate DSM chunk for parallel Index[Only]Scan instrum
In-Reply-To: <E1w9t9g-003Itk-22@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox