agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix shared memory size of template code for custom fixed-sized p
Date: Mon, 06 Apr 2026 23:24:55 +0000
Message-ID: <E1w9tJO-003Iyl-2x@gemulon.postgresql.org> (raw)
Fix shared memory size of template code for custom fixed-sized pgstats
On HEAD, the template code for custom fixed-sized pgstats is in the test
module test_custom_stats. On REL_18_STABLE, this code lives in the test
module injection_points.
Both cases were underestimating the size of the shared memory area
required for the storage of the stats data, using a single entry rather
than the whole area. This underestimation meant that there was no
memory allocated for the LWLock required for the stats, and even more.
This problem would be also misleading for extension developers looking
at this code.
This issue has been noticed while digging into a different bug reported
by Heikki Linnakangas, showing that the underestimation was causing
failures in the TAP tests of the test modules for 32-bit builds. The
other issue reported, related to the memory allocation of custom
fixed-sized pgstats, will be fixed in a follow-up commit.
Discussion: https://postgr.es/m/adMk_lWbnz3HDOA8@paquier.xyz
Backpatch-through: 18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/98979578055ffba3bd520adcec00881f72fc2861
Modified Files
--------------
src/test/modules/test_custom_stats/test_custom_fixed_stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
view thread (2+ messages) latest in thread
Message-ID: <E1w9tJO-003Iyl-2x@gemulon.postgresql.org>
Permalink: ../E1w9tJO-003Iyl-2x@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1w9tJO-003Iyl-2x@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix shared memory size of template code for custom fixed-sized p
In-Reply-To: <E1w9tJO-003Iyl-2x@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox