agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Split CREATE STATISTICS error reasons out into errdetails
Date: Tue, 07 Apr 2026 04:38:49 +0000
Message-ID: <E1w9yDA-003Kzi-1F@gemulon.postgresql.org> (raw)

Split CREATE STATISTICS error reasons out into errdetails

Some errmsgs in statscmds.c were phrased as "...cannot be used
because...". Put the reasons into errdetails. While at it, switch
from passive voice to "cannot create..." for the errmsg.

Author: Yugo Nagata <nagata@sraoss.co.jp>
Suggested-by: John Naylor <johncnaylorls@gmail.com>
Discussion: https://postgr.es/m/CANWCAZaZeX0omWNh_ZbD_JVujzYQdRUW8UZOQ4dWh9Sg7OcAow@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/51098839cfb40dc496bb48fe4ea14d19170099ac

Modified Files
--------------
src/backend/commands/statscmds.c        | 17 +++++++++++------
src/test/regress/expected/stats_ext.out |  3 ++-
2 files changed, 13 insertions(+), 7 deletions(-)



Message-ID: <E1w9yDA-003Kzi-1F@gemulon.postgresql.org>
Permalink:  ../E1w9yDA-003Kzi-1F@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1w9yDA-003Kzi-1F@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Split CREATE STATISTICS error reasons out into errdetails
  In-Reply-To: <E1w9yDA-003Kzi-1F@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox