agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: John Naylor <john.naylor@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use .h for the file containing the page checksum code fragment
Date: Tue, 07 Apr 2026 08:53:32 +0000
Message-ID: <E1wA2Bf-003MpH-27@gemulon.postgresql.org> (raw)
Use .h for the file containing the page checksum code fragment
Commit 5e13b0f24 used a .c file for a file containing a code fragment,
to avoid adding an exception to headerscheck. That turned out to be
too clever, since it meant installation didn't happen by the usual
mechanism. Make it look like a normal header and add the requisite
exception.
Bug: #19450
Reported-by: RekGRpth <rekgrpth@gmail.com>
Discussion: https://postgr.es/m/19450-bb0612c50c6786e5@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8c3e22a8f8b9af94b519b6e223db0912d552093e
Modified Files
--------------
src/backend/storage/page/checksum.c | 4 ++--
.../storage/{checksum_block.inc.c => checksum_block_internal.h} | 6 +++---
src/include/storage/checksum_impl.h | 2 +-
src/tools/pginclude/headerscheck | 4 +++-
4 files changed, 9 insertions(+), 7 deletions(-)
Message-ID: <E1wA2Bf-003MpH-27@gemulon.postgresql.org>
Permalink: ../E1wA2Bf-003MpH-27@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wA2Bf-003MpH-27@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use .h for the file containing the page checksum code fragment
In-Reply-To: <E1wA2Bf-003MpH-27@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox