agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix valgrind failure
Date: Tue, 07 Apr 2026 09:15:34 +0000
Message-ID: <E1wA2Wz-003N0N-2Y@gemulon.postgresql.org> (raw)
Fix valgrind failure
Buildfarm member skink reports that the new REPACK code is trying to
write uninitialized bytes to disk, which correspond to padding space in
the SerializedSnapshotData struct. Silence that by initializing the
memory in SerializeSnapshot() to all zeroes.
Co-authored-by: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Co-authored-by: Álvaro Herrera <alvherre@kurilemu.de>
Discussion: https://postgr.es/m/1976915.1775537087@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5bcc3fbd196ccbec55c2ce6b58d6946f06cf6213
Modified Files
--------------
src/backend/commands/repack_worker.c | 2 +-
src/backend/utils/time/snapmgr.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
view thread (3+ messages) latest in thread
Message-ID: <E1wA2Wz-003N0N-2Y@gemulon.postgresql.org>
Permalink: ../E1wA2Wz-003N0N-2Y@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wA2Wz-003N0N-2Y@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@kurilemu.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix valgrind failure
In-Reply-To: <E1wA2Wz-003N0N-2Y@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox