agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix harmless leftover in _hash_kill_items()
Date: Tue, 07 Apr 2026 14:38:31 +0000
Message-ID: <E1wA7ZX-003PVQ-0I@gemulon.postgresql.org> (raw)
Fix harmless leftover in _hash_kill_items()
Checking for 'havePin' is sufficient here. An earlier version of the
patch didn't have the 'havePin' variable and used
'so->hashso_bucket_buf == so->currPos.buf' as the condition when both
locking and unlocking the page. The havePin variable was added later
during development, but the unlocking condition wasn't fully
updated. Tidy it up.
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://www.postgresql.org/message-id/b9de8d05-3b02-4a27-9b0b-03972fa4bfd3@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/979387f1885111c72b84af535f23de4e3e913206
Modified Files
--------------
src/backend/access/hash/hashutil.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Message-ID: <E1wA7ZX-003PVQ-0I@gemulon.postgresql.org>
Permalink: ../E1wA7ZX-003PVQ-0I@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wA7ZX-003PVQ-0I@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix harmless leftover in _hash_kill_items()
In-Reply-To: <E1wA7ZX-003PVQ-0I@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox