agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reduce presence of syscache.h in src/include/
Date: Wed, 08 Apr 2026 23:53:19 +0000
Message-ID: <E1wAchy-0003qD-1L@gemulon.postgresql.org> (raw)
Reduce presence of syscache.h in src/include/
ee642cccc43c has added syscache.h in inval.h and objectaddress.h,
enlarging by a lot the footprint of this header, particularly via
objectaddress.h. A change in syscache.h would cause a lot more files to
be recompiled.
This commit reduces the presence of syscache.h by switching to a direct
use of syscache_ids.h in inval.h and objectaddress.h, where the enum
SysCacheIdentifier is defined. genbki.pl gains an #ifndef block for
this header, so as its inclusion is more controlled.
Reported-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/vlcexdcimsmvu3aplt2yxpfndkgtuvjsrms2fdl46rbw3k2kug@drspkoxlaije
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e0fa5bd146564d9d05cac15bdcba65b7860d2b91
Modified Files
--------------
src/backend/catalog/genbki.pl | 10 ++++++++--
src/include/catalog/objectaddress.h | 2 +-
src/include/utils/inval.h | 2 +-
3 files changed, 10 insertions(+), 4 deletions(-)
Message-ID: <E1wAchy-0003qD-1L@gemulon.postgresql.org>
Permalink: ../E1wAchy-0003qD-1L@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wAchy-0003qD-1L@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reduce presence of syscache.h in src/include/
In-Reply-To: <E1wAchy-0003qD-1L@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox