agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalRe
Date: Thu, 09 Apr 2026 06:32:01 +0000
Message-ID: <E1wAivo-0006XD-2V@gemulon.postgresql.org> (raw)
Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalReason
Commit 15910b1c363 PROCSIG_SLOTSYNC_MESSAGE in the middle of
enum ProcSignalReason, breaking the ABI.
Fix this by moving PROCSIG_SLOTSYNC_MESSAGE to just before the last entry,
NUM_PROCSIGNALS, to restore ordering of other entries.
This increases the value of NUM_PROCSIGNALS, which technically changes the ABI.
However, since it represents the number of enum entries (not a signal reason),
and no affected third-party code is known, this change will be recorded in
.abi-compliance-history later.
Per buildfarm member crake.
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Nisha Moond <nisha.moond412@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwH_AAbtsiYDJt65N7_4PJ0CgOJmBEaCq68e5_tcuG_vXw@mail.gmail.com
Backpatch-through: 17 only
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/586f4266fb4945f6ea3564b9c1bab093eb74bee4
Modified Files
--------------
src/include/storage/procsignal.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
view thread (2+ messages)
Message-ID: <E1wAivo-0006XD-2V@gemulon.postgresql.org>
Permalink: ../E1wAivo-0006XD-2V@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wAivo-0006XD-2V@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: fujii@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix ABI break by moving PROCSIG_SLOTSYNC_MESSAGE in ProcSignalRe
In-Reply-To: <E1wAivo-0006XD-2V@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox