agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Zero-fill private_data when attaching an injection point
Date: Fri, 10 Apr 2026 02:17:46 +0000
Message-ID: <E1wB1RK-000EKZ-0T@gemulon.postgresql.org> (raw)

Zero-fill private_data when attaching an injection point

InjectionPointAttach() did not initialize the private_data buffer of the
shared memory entry before (perhaps partially) overwriting it.  When the
private data is set to NULL by the caler, the buffer was left
uninitialized.  If set, it could have stale contents.

The buffer is initialized to zero, so as the contents recorded when a
point is attached are deterministic.

Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/CAA5RZ0tsGHu2h6YLnVu4HiK05q+gTE_9WVUAqihW2LSscAYS-g@mail.gmail.com
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5b5bf51e435304b2043db46b65455747de2af1f5

Modified Files
--------------
src/backend/utils/misc/injection_point.c | 1 +
1 file changed, 1 insertion(+)



view thread (3+ messages)  latest in thread

Message-ID: <E1wB1RK-000EKZ-0T@gemulon.postgresql.org>
Permalink:  ../E1wB1RK-000EKZ-0T@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wB1RK-000EKZ-0T@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Zero-fill private_data when attaching an injection point
  In-Reply-To: <E1wB1RK-000EKZ-0T@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox