agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Masahiko Sawada <msawada@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix unstable log verification in test_autovacuum.
Date: Fri, 10 Apr 2026 23:02:13 +0000
Message-ID: <E1wBKrc-000N44-21@gemulon.postgresql.org> (raw)
Fix unstable log verification in test_autovacuum.
The test in test_autovacuum was unstable because it called
log_contains() immediately after verifying autovacuum_count in
pg_stat_user_tables. This created a race condition where the
statistics could be updated before the autovacuum logs were fully
flushed to disk.
This commit replaces log_contains() with wait_for_log() to ensure the
test waits for the parallel vacuum messages to appear. Additionally,
remove the checks of the autovacuum count. Verifying the log messages
is sufficient to confirm parallel autovacuum behavior, as logging is
only enabled for the specific table under test.
Per report from buildfarm member flaviventris.
Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/525d0f48-93f7-493f-a988-f39b460a79bc@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c22d115f1d13d7c1b89ec20abaa02ebeb811b9dd
Modified Files
--------------
.../test_autovacuum/t/001_parallel_autovacuum.pl | 40 +++++++---------------
1 file changed, 12 insertions(+), 28 deletions(-)
view thread (2+ messages)
Message-ID: <E1wBKrc-000N44-21@gemulon.postgresql.org>
Permalink: ../E1wBKrc-000N44-21@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wBKrc-000N44-21@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: msawada@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix unstable log verification in test_autovacuum.
In-Reply-To: <E1wBKrc-000N44-21@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox