agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
pgsql: Fix typo in comment.
2+ messages / 2 participants
[nested] [flat]

* pgsql: Fix typo in comment.
@ 2009-07-07 18:49 Tom Lane <tgl@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: tgl@postgresql.org @ 2009-07-07 18:49 UTC (permalink / raw)
  To: pgsql-committers

Log Message:
-----------
Fix typo in comment.

Modified Files:
--------------
    pgsql/src/include/catalog:
        pg_proc.h (r1.545 -> r1.546)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h?r1=1.545&r2=1.546)




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Fix unstable log verification in test_autovacuum.
@ 2026-04-10 23:02 Masahiko Sawada <msawada@postgresql.org>
  0 siblings, 0 replies; 2+ messages in thread

From: Masahiko Sawada @ 2026-04-10 23:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix unstable log verification in test_autovacuum.

The test in test_autovacuum was unstable because it called
log_contains() immediately after verifying autovacuum_count in
pg_stat_user_tables. This created a race condition where the
statistics could be updated before the autovacuum logs were fully
flushed to disk.

This commit replaces log_contains() with wait_for_log() to ensure the
test waits for the parallel vacuum messages to appear. Additionally,
remove the checks of the autovacuum count. Verifying the log messages
is sufficient to confirm parallel autovacuum behavior, as logging is
only enabled for the specific table under test.

Per report from buildfarm member flaviventris.

Author: Sami Imseih <samimseih@gmail.com>
Discussion: https://postgr.es/m/525d0f48-93f7-493f-a988-f39b460a79bc@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c22d115f1d13d7c1b89ec20abaa02ebeb811b9dd

Modified Files
--------------
.../test_autovacuum/t/001_parallel_autovacuum.pl   | 40 +++++++---------------
1 file changed, 12 insertions(+), 28 deletions(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2026-04-10 23:02 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-07 18:49 pgsql: Fix typo in comment. Tom Lane <tgl@postgresql.org>
2026-04-10 23:02 pgsql: Fix unstable log verification in test_autovacuum. Masahiko Sawada <msawada@postgresql.org>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox