agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Richard Guo <rguo@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix estimate_array_length error with set-operation array coercio
Date: Sat, 11 Apr 2026 07:42:56 +0000
Message-ID: <E1wBSzX-000QOc-2z@gemulon.postgresql.org> (raw)

Fix estimate_array_length error with set-operation array coercions

When a nested set operation's output type doesn't match the parent's
expected type, recurse_set_operations builds a projection target list
using generate_setop_tlist with varno 0.  If the required type
coercion involves an ArrayCoerceExpr, estimate_array_length could be
called on such a Var, and would pass it to examine_variable, which
errors in find_base_rel because varno 0 has no valid relation entry.

Fix by skipping the statistics lookup for Vars with varno 0.

Bug introduced by commit 9391f7152.  Back-patch to v17, where
estimate_array_length was taught to use statistics.

Reported-by: Justin Pryzby <pryzby@telsasoft.com>
Author: Tender Wang <tndrwang@gmail.com>
Reviewed-by: Richard Guo <guofenglinux@gmail.com>
Discussion: https://postgr.es/m/adjW8rfPDkplC7lF@pryzbyj2023
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/77d0e82e58854cfa5e2c4f365a97f16c0d91c394

Modified Files
--------------
src/backend/utils/adt/selfuncs.c    | 12 ++++++++++++
src/test/regress/expected/union.out | 17 +++++++++++++++++
src/test/regress/sql/union.sql      |  4 ++++
3 files changed, 33 insertions(+)



view thread (3+ messages)  latest in thread

Message-ID: <E1wBSzX-000QOc-2z@gemulon.postgresql.org>
Permalink:  ../E1wBSzX-000QOc-2z@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wBSzX-000QOc-2z@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rguo@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix estimate_array_length error with set-operation array coercio
  In-Reply-To: <E1wBSzX-000QOc-2z@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox