agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Honor passed-in database OIDs in pgstat_database.c
Date: Sat, 11 Apr 2026 08:09:44 +0000
Message-ID: <E1wBTPU-000QXD-0o@gemulon.postgresql.org> (raw)
Honor passed-in database OIDs in pgstat_database.c
Three routines in pgstat_database.c incorrectly ignore the database OID
provided by their caller, using MyDatabaseId instead:
- pgstat_report_connect()
- pgstat_report_disconnect()
- pgstat_reset_database_timestamp()
The first two functions, for connection and disconnection, each have a
single caller that already passes MyDatabaseId. This was harmless,
still incorrect.
The timestamp reset function also has a single caller, but in this case
the issue has a real impact: it fails to reset the timestamp for the
shared-database entry (datid=0) when operating on shared objects. This
situation can occur, for example, when resetting counters for shared
relations via pg_stat_reset_single_table_counters().
There is currently one test in the tree that checks the reset of a
shared relation, for pg_shdescription, we rely on it to check what is
stored in pg_stat_database. As stats_reset may be NULL, two resets are
done to provide a baseline for comparison.
Author: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Dapeng Wang <wangdp20191008@gmail.com>
Discussion: https://postgr.es/m/ABBD5026-506F-4006-A569-28F72C188693@gmail.com
Backpatch-through: 15
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/80156cee06b9d257251d72379ac43f9b88bd13e1
Modified Files
--------------
src/backend/utils/activity/pgstat_database.c | 6 +++---
src/test/regress/expected/stats.out | 18 ++++++++++++++++++
src/test/regress/sql/stats.sql | 8 ++++++++
3 files changed, 29 insertions(+), 3 deletions(-)
view thread (5+ messages) latest in thread
Message-ID: <E1wBTPU-000QXD-0o@gemulon.postgresql.org>
Permalink: ../E1wBTPU-000QXD-0o@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wBTPU-000QXD-0o@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Honor passed-in database OIDs in pgstat_database.c
In-Reply-To: <E1wBTPU-000QXD-0o@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox