agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix excessive logging in idle slotsync worker.
Date: Mon, 13 Apr 2026 04:42:50 +0000
Message-ID: <E1wC98L-000jtI-1a@gemulon.postgresql.org> (raw)
Fix excessive logging in idle slotsync worker.
The slotsync worker was incorrectly identifying no-op states as successful
updates, triggering a busy loop to sync slots that logged messages every
200ms. This patch corrects the logic to properly classify these states,
enabling the worker to respect normal sleep intervals when no work is
performed.
Reported-by: Fujii Masao <masao.fujii@gmail.com>
Author: Zhijie Hou <houzj.fnst@fujitsu.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: shveta malik <shveta.malik@gmail.com>
Backpatch-through: 17, where it was introduced
Discussion: https://postgr.es/m/CAHGQGwF6zG9Z8ws1yb3hY1VqV-WT7hR0qyXCn2HdbjvZQKufDw@mail.gmail.com
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/91741b7cb7b5e0f0eb5100a548798b5a395cd3b5
Modified Files
--------------
src/backend/replication/logical/slotsync.c | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
view thread (3+ messages) latest in thread
Message-ID: <E1wC98L-000jtI-1a@gemulon.postgresql.org>
Permalink: ../E1wC98L-000jtI-1a@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wC98L-000jtI-1a@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix excessive logging in idle slotsync worker.
In-Reply-To: <E1wC98L-000jtI-1a@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox