agora inbox for pgsql-committers@postgresql.orghelp / color / mirror / Atom feed
pgsql: Fix excessive logging in idle slotsync worker. 3+ messages / 1 participants [nested] [flat]
* pgsql: Fix excessive logging in idle slotsync worker. @ 2026-04-13 04:42 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2026-04-13 04:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix excessive logging in idle slotsync worker. The slotsync worker was incorrectly identifying no-op states as successful updates, triggering a busy loop to sync slots that logged messages every 200ms. This patch corrects the logic to properly classify these states, enabling the worker to respect normal sleep intervals when no work is performed. Reported-by: Fujii Masao <masao.fujii@gmail.com> Author: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Backpatch-through: 17, where it was introduced Discussion: https://postgr.es/m/CAHGQGwF6zG9Z8ws1yb3hY1VqV-WT7hR0qyXCn2HdbjvZQKufDw@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/85c17f612af7b9c47a9828805686f0dd2433cdf1 Modified Files -------------- src/backend/replication/logical/slotsync.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix excessive logging in idle slotsync worker. @ 2026-04-13 04:42 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2026-04-13 04:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix excessive logging in idle slotsync worker. The slotsync worker was incorrectly identifying no-op states as successful updates, triggering a busy loop to sync slots that logged messages every 200ms. This patch corrects the logic to properly classify these states, enabling the worker to respect normal sleep intervals when no work is performed. Reported-by: Fujii Masao <masao.fujii@gmail.com> Author: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Backpatch-through: 17, where it was introduced Discussion: https://postgr.es/m/CAHGQGwF6zG9Z8ws1yb3hY1VqV-WT7hR0qyXCn2HdbjvZQKufDw@mail.gmail.com Branch ------ REL_18_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/540fe8fb5c22a6c724513f62daaae79af5d559cb Modified Files -------------- src/backend/replication/logical/slotsync.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
* pgsql: Fix excessive logging in idle slotsync worker. @ 2026-04-13 04:42 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 3+ messages in thread From: Amit Kapila @ 2026-04-13 04:42 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix excessive logging in idle slotsync worker. The slotsync worker was incorrectly identifying no-op states as successful updates, triggering a busy loop to sync slots that logged messages every 200ms. This patch corrects the logic to properly classify these states, enabling the worker to respect normal sleep intervals when no work is performed. Reported-by: Fujii Masao <masao.fujii@gmail.com> Author: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Backpatch-through: 17, where it was introduced Discussion: https://postgr.es/m/CAHGQGwF6zG9Z8ws1yb3hY1VqV-WT7hR0qyXCn2HdbjvZQKufDw@mail.gmail.com Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/91741b7cb7b5e0f0eb5100a548798b5a395cd3b5 Modified Files -------------- src/backend/replication/logical/slotsync.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-04-13 04:42 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-13 04:42 pgsql: Fix excessive logging in idle slotsync worker. Amit Kapila <akapila@postgresql.org> 2026-04-13 04:42 pgsql: Fix excessive logging in idle slotsync worker. Amit Kapila <akapila@postgresql.org> 2026-04-13 04:42 pgsql: Fix excessive logging in idle slotsync worker. Amit Kapila <akapila@postgresql.org>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox