agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_createsubscriber: Use logging.c log file callback
Date: Mon, 13 Apr 2026 08:50:41 +0000
Message-ID: <E1wCD0D-000lPt-0v@gemulon.postgresql.org> (raw)
pg_createsubscriber: Use logging.c log file callback
This reverts commit 6b5b7eae3ae, where a new logging API layer was
introduced locally in pg_createsubscriber. Instead, use the log file
callback introduced in logging.c. This new approach is simpler,
eliminates code duplication, and doesn't require any caller changes or
NLS updates (which the previous commit missed).
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CAEqnbaUthOQARV1dscGvB_EsqC-YfxiM6rWkVDHc%2BG%2Bf4oSUHw%4...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/847336ba53af2d140563cdf9f2b0c4f678378a54
Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 832 ++++++++++------------------
1 file changed, 279 insertions(+), 553 deletions(-)
Message-ID: <E1wCD0D-000lPt-0v@gemulon.postgresql.org>
Permalink: ../E1wCD0D-000lPt-0v@gemulon.postgresql.org/
Also on: postgresql.org/message-id/E1wCD0D-000lPt-0v@gemulon.postgresql.org
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_createsubscriber: Use logging.c log file callback
In-Reply-To: <E1wCD0D-000lPt-0v@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox