agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: MSVC: Turn missing function declaration into an error
Date: Thu, 16 Apr 2026 07:53:14 +0000
Message-ID: <E1wDHXF-001DYX-2Y@gemulon.postgresql.org> (raw)

MSVC: Turn missing function declaration into an error

Calling an undeclared function should be an error as of C99, and GCC
and Clang do that, but MSVC doesn't even warn about it in the default
warning level.  (Commit c86d2ccdb35 fixed an instance of this
problem.)  This turns on this warning and makes it an error by
default, to match other compilers.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/1142ad86-e475-41b3-aeee-c6ad913064fa%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a51ec16db7aa1688d0083911db78e17ff7f26ba

Modified Files
--------------
meson.build | 3 +++
1 file changed, 3 insertions(+)



Message-ID: <E1wDHXF-001DYX-2Y@gemulon.postgresql.org>
Permalink:  ../E1wDHXF-001DYX-2Y@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1wDHXF-001DYX-2Y@gemulon.postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: MSVC: Turn missing function declaration into an error
  In-Reply-To: <E1wDHXF-001DYX-2Y@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox